Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CE-1044-Add-Method-complaint-was-received-as-a-filter-option-for-CEEB #678

Conversation

dmitri-korin-bcps
Copy link
Contributor

@dmitri-korin-bcps dmitri-korin-bcps commented Sep 27, 2024

Description

This PR adds a method complaint was received as a filter option. Visibility of the new filter is controlled by a feature flag. Currently it is only visible for CEEB users

Fixes # (CE-1044)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

  • Sign in as a user that is a member of CEEB role. Click "Filters" button to show the filters side bar. Check if the Complaint Method filter show up. Select some value from the Complaint Method filter. Check if complaint list is filtered. Check if other filter actions like removing, stacking, opening and closing the filter selector continue to work. Check if Map view can be filtered using the same steps

Note: Currently our test data does not have any complaints for which complaint method field is populated. To set up test data the column the "comp_mthd_recv_cd_agcy_cd_xref_guid"of "public.complaint" table need to be updated with the guilds from the "comp_mthd_recv_cd_agcy_cd_xref_guid" column of "public.comp_mthd_recv_cd_agcy_cd_xref" table.

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@dmitri-korin-bcps dmitri-korin-bcps changed the title feat:CE-1044-Add-Method-complaint-was-received-as-a-filter-option-for-CEEB feat: CE-1044-Add-Method-complaint-was-received-as-a-filter-option-for-CEEB Sep 27, 2024
Update SQL to make it deploy
Copy link

sonarcloud bot commented Sep 27, 2024

Copy link
Collaborator

@afwilcox afwilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I made a minor change to the SQL script in order to get it to run, but other than that it all looks good.

@afwilcox afwilcox merged commit 99acf57 into release/orca Sep 28, 2024
15 checks passed
@afwilcox afwilcox deleted the feature/CE-1044-Add-Method-complaint-was-received-as-a-filter-option-for-CEEB branch September 28, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants